Change default boot mode to UEFI for tests#1151
Change default boot mode to UEFI for tests#1151KKoukiou wants to merge 1 commit intorhinstaller:mainfrom
Conversation
Summary of ChangesHello @KKoukiou, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request fundamentally alters the testing environment's default boot mode from BIOS to UEFI. This change simplifies test configuration by making UEFI the implicit boot mode, thereby reducing the need for explicit declarations in individual test cases. The core logic for determining the boot environment has been updated to reflect this new default, ensuring consistency and forward compatibility with modern system architectures. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request changes the default boot mode for tests from BIOS to UEFI. This involves inverting the logic for checking the boot mode (from is_efi to is_bios) and updating default values. The changes are applied consistently across the test suite infrastructure. As part of this, redundant @run_boot("efi") decorators are removed from tests, since EFI is now the default. The changes look good and align with the PR's goal. I have one suggestion to simplify the test skipping logic for improved readability and maintainability.
| if self.is_bios and "bios" not in boot_modes: | ||
| self.skipTest("Skipping for BIOS boot mode") | ||
| elif not self.is_bios and "efi" not in boot_modes: | ||
| self.skipTest("Skipping for EFI boot mode") |
There was a problem hiding this comment.
This logic for skipping tests based on the boot mode can be simplified to be more concise and avoid repetition. By determining the current firmware mode first, you can use a single if statement to check if it's in the allowed boot_modes.
| if self.is_bios and "bios" not in boot_modes: | |
| self.skipTest("Skipping for BIOS boot mode") | |
| elif not self.is_bios and "efi" not in boot_modes: | |
| self.skipTest("Skipping for EFI boot mode") | |
| firmware = "bios" if self.is_bios else "efi" | |
| if firmware not in boot_modes: | |
| self.skipTest(f"Skipping for {firmware.upper()} boot mode") |
Update all references to use inverted logic.
Also remove @run_boot('efi') decorators from test files as EFI is now
default.
KKoukiou
force-pushed
the
convert-tests-to-uefi-default
branch
from
39f3542 to
d995c7e
Compare
1 participant
Update all references to use inverted logic.
Also remove @run_boot('efi') decorators from test files as EFI is now default.